Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Changed export strategy in index files #11113

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

michelengelen
Copy link
Member


Previously anyone who needed the *Props type (or *Slots/*SlotProps) had to import those from within the component file.

Diff

- import { BarChart } from '@mui/x-charts/BarChart';
- import { BarChartProps } from '@mui/x-charts/BarChart/BarChart';
+ import { BarChart, BarChartProps } from '@mui/x-charts/BarChart';

Fixes #11099

@michelengelen michelengelen added typescript enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge component: charts This is the name of the generic UI component, not the React module! labels Nov 21, 2023
@michelengelen michelengelen requested a review from a team November 21, 2023 08:54
@michelengelen michelengelen self-assigned this Nov 21, 2023
@mui-bot
Copy link

mui-bot commented Nov 21, 2023

Deploy preview: https://deploy-preview-11113--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 118c5b0

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
Could you run yarn docs:api to regenerate the exportsfile? 🤔

@michelengelen
Copy link
Member Author

@LukasTy is this the test you were talking about 😛

[0]       AssertionError: expected 'brandyear' to equal 'yearbrand'
[0]       + expected - actual
[0] 
[0]       -brandyear
[0]       +yearbrand

@LukasTy
Copy link
Member

LukasTy commented Nov 21, 2023

LukasTy is this the test you were talking about 😛

Yup. 🙈
Could you try syncing with next? 🤔

@michelengelen michelengelen reopened this Nov 22, 2023
@michelengelen
Copy link
Member Author

sry @LukasTy ... something went horribly wrong with the sync and rebase. Had to re-apply the changes. Could you have a quick glance if everything is ok?

@LukasTy
Copy link
Member

LukasTy commented Nov 23, 2023

Could you have a quick glance if everything is ok?

@michelengelen All still looks good to me. 👌

@michelengelen michelengelen merged commit 20eb1a7 into mui:next Nov 23, 2023
19 checks passed
@michelengelen michelengelen deleted the 11099/charts-exports branch November 23, 2023 11:03
michelengelen added a commit to michelengelen/mui-x that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] Can't import Prop types from @mui/x-charts for BarChart
3 participants