Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve the prop descriptions of DayCalendar #11158

Merged
merged 4 commits into from
Nov 24, 2023
Merged

[docs] Improve the prop descriptions of DayCalendar #11158

merged 4 commits into from
Nov 24, 2023

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle self-assigned this Nov 23, 2023
@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Nov 23, 2023
@flaviendelangle flaviendelangle changed the title [docs] Improve the prop descriptions of DayCalendar [docs] Improve the prop descriptions of DayCalendar Nov 23, 2023
@mui-bot
Copy link

mui-bot commented Nov 23, 2023 •
edited

Deploy preview: https://deploy-preview-11158--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 97bb244

noraleonte
noraleonte approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here make a lot of sense to me 👍 Nice improvement 💯

flaviendelangle and others added 2 commits November 24, 2023 14:31
@flaviendelangle @LukasTy
Update packages/x-date-pickers/src/DateCalendar/DayCalendar.tsx
8ea8e61 
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle
Review: Lukas
97bb244
@flaviendelangle flaviendelangle merged commit 2cbfa75 into mui:next Nov 24, 2023
17 checks passed
@flaviendelangle flaviendelangle deleted the reword-day-calendar-props branch November 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@noraleonte noraleonte noraleonte approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flaviendelangle @mui-bot @LukasTy @noraleonte