[DataGrid] Added a guard for reorder cells

[michelengelen]

• I have followed (at least) the PR section of the contributing guide.

---

Prevents disableColumnReorder prop from disabling dragevents on the reorder cell.

Fixes #11126

[flaviendelangle]

This whole condition is way to complex and hard to read.
IMHO it should be a full method or at list a variable assignment.

It was already too complex before your addition though 😬

[michelengelen]

thats true (😛) ... I'll check if I can extract that into a helper

[michelengelen]

OK, I did look around a bit.

mui-x/packages/grid/x-data-grid/src/components/GridRow.tsx

Lines 280 to 285 in 891cea1

	const disableDragEvents =
	(disableColumnReorder && column.disableReorder) ||
	(!rowReordering &&
	!!sortModel.length &&
	treeDepth > 1 &&
	Object.keys(editRowsState).length > 0);

Is basically duplicated in the drag handlers. That seems a bit weird.
My proposal would be to allow the drag events to being published, but handle the event execution like before.
For reference the row reorder handles it here:

mui-x/packages/grid/x-data-grid-pro/src/hooks/features/rowReorder/useGridRowReorder.tsx

Lines 75 to 77 in 891cea1

	const isRowReorderDisabled = React.useMemo((): boolean => {
	return !props.rowReordering || !!sortModel.length || treeDepth !== 1;
	}, [props.rowReordering, sortModel, treeDepth]);

And the column reorder here:

mui-x/packages/grid/x-data-grid-pro/src/hooks/features/columnReorder/useGridColumnReorder.tsx

Lines 88 to 90 in 891cea1

	if (props.disableColumnReorder || params.colDef.disableReorder) {
	return;
	}

I would still keep the disableDragEvents variable for this case:

const disableDragEvents = Object.keys(editRowsState).length > 0;

@flaviendelangle WDYT?

[flaviendelangle]

This can make sense
I'll let @cherniavskii validate because my knowledge of the codebase is rusted.

[cherniavskii]

Adding some context on why we disable drag handlers: #4841

[michelengelen]

Since disabling the dragEvents is beneficial (thanks for pointing that out @cherniavskii) I just renamed and restructured it a tiny bit to make it more readable at least.

[mui-bot]

Deploy preview: https://deploy-preview-11159--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2e8441e

[cherniavskii]

Seems like some of the changes above broke a few tests

[michelengelen]

Seems like some of the changes above broke a few tests

@cherniavskii fixed (finally 😅 )

[cherniavskii]

Is this expression correct? I would expect it to be:

 const canReorderRow = rowReordering && !sortModel.length && treeDepth <= 1 && !isEditingRows;

[michelengelen]

nice catch ... it was working like this as well ... but the cases where it shouldn't be working did work as well, so that would have been bad! Thanks for catching that!