Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add recipe for sorting row groups by the number of child rows #11164

Merged
merged 5 commits into from
Jan 26, 2024
Merged

[docs] Add recipe for sorting row groups by the number of child rows #11164

merged 5 commits into from
Jan 26, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Nov 23, 2023 •
edited

@cherniavskii cherniavskii added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! feature: Sorting Related to the data grid Sorting feature feature: Row grouping Related to the data grid Row grouping feature customization: extend Logic customizability recipe labels Nov 23, 2023
@mui-bot
Copy link

mui-bot commented Nov 23, 2023 •
edited

Deploy preview: https://deploy-preview-11164--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 79b211d

@cherniavskii cherniavskii mentioned this pull request Jan 23, 2024
Merged
@cherniavskii
Copy link
Member Author

cherniavskii commented Jan 23, 2024 •
edited

Blocked by #11792

@cherniavskii cherniavskii marked this pull request as ready for review January 23, 2024 18:25
MBilalShafi
MBilalShafi approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I couldn't grab it right now but I remember discussing this use case on some GH issue too 👍

docs/data/data-grid/recipes-row-grouping/RowGroupingSortByChildRows.tsx Outdated
],
},
}}
groupingColDef={{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we stabilize the reference to this prop?

  1. getGroupingColDefs might recompute on each render which may yield some rendering side effects.
  2. In docs, we suggest to keep stable references for all non-primitive props, so it'd be better to follow the same in our demos.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍🏻

@cherniavskii cherniavskii merged commit 1a4b417 into mui:next Jan 26, 2024
17 checks passed
@cherniavskii cherniavskii deleted the sort-groups-by-child-rows branch January 26, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability docs Improvements or additions to the documentation feature: Row grouping Related to the data grid Row grouping feature feature: Sorting Related to the data grid Sorting feature recipe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cherniavskii @mui-bot @romgrk @MBilalShafi