Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Apply labelStyle and tickLabelStyle props on <ChartsYAxis /> #11180

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

akamfoad
Copy link
Contributor

@akamfoad akamfoad commented Nov 25, 2023

labelStyle prop on YAxis didn't have any effect since it wasn't applied to the axis label props, now this issue is fixed.

Fixes #11172

@mui-bot
Copy link

mui-bot commented Nov 25, 2023

Deploy preview: https://deploy-preview-11180--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9d32c5a

@alexfauquette alexfauquette changed the title fix: labelStyle wasn't passed to axis label props [charts] Applly labelStyle and tickLabelStyleprops for <ChartsYAxis /> Nov 27, 2023
@alexfauquette
Copy link
Member

Thanks for the fix. Could you also include the tickLabelStyle the same way?

@LukasTy LukasTy added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! labels Nov 27, 2023
@LukasTy LukasTy changed the title [charts] Applly labelStyle and tickLabelStyleprops for <ChartsYAxis /> [charts] Apply labelStyle and tickLabelStyle props on <ChartsYAxis /> Nov 27, 2023
@akamfoad
Copy link
Contributor Author

of course @alexfauquette done

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@alexfauquette alexfauquette merged commit 0109ad5 into mui:next Nov 27, 2023
17 checks passed
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] labelStyle prop not working
4 participants