Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Fix export strategy #11235

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Nov 29, 2023

Take time to clean how components are exported to have a consistent behavior across components

  • Charts folders
  • Axis
  • Legend
  • Tooltip

Fix #11234
Fix #11136

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Nov 29, 2023
@mui-bot
Copy link

mui-bot commented Nov 29, 2023

Deploy preview: https://deploy-preview-11235--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 470a6f9

@alexfauquette alexfauquette marked this pull request as ready for review November 29, 2023 13:31
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... one comment though: There are a lot of proptypes that have no description and won't show up in the component API page, right?

@alexfauquette
Copy link
Member Author

There are a lot of proptypes that have no description and won't show up in the component API page, right?

Yes but at this level of internal components, I bet user will go in the codebase to know what it does

@alexfauquette alexfauquette merged commit ed16da8 into mui:next Nov 30, 2023
17 checks passed
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Nov 30, 2023
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Nov 30, 2023
@micmcg
Copy link

micmcg commented Nov 30, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
4 participants