Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Make header filters feature stable #11243

Merged
merged 6 commits into from
Dec 5, 2023
Merged

[DataGridPro] Make header filters feature stable #11243

merged 6 commits into from
Dec 5, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Nov 29, 2023 •
edited

Part of #10556

TODOs:

  • Add the change to migration guide and changelog
  • Add rename codemod (follow-up PR)

Changelog

Breaking changes

  • The header filters feature is now stable. unstable_ prefix is removed from prop headerFilters and related exports.

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v7.x labels Nov 29, 2023
@mui-bot
Copy link

mui-bot commented Nov 29, 2023 •
edited

Deploy preview: https://deploy-preview-11243--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against c12a702

@MBilalShafi MBilalShafi added the feature: Filtering on header Related to the header filtering (Pro) feature label Nov 29, 2023
@MBilalShafi MBilalShafi mentioned this pull request Nov 29, 2023
Open
45 tasks
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 30, 2023
michelengelen
michelengelen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 1, 2023
@MBilalShafi MBilalShafi merged commit b06480f into mui:next Dec 5, 2023
17 checks passed
@MBilalShafi MBilalShafi deleted the breaking-changes/header-filters branch December 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@michelengelen michelengelen michelengelen approved these changes

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Filtering on header Related to the header filtering (Pro) feature v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MBilalShafi @mui-bot @cherniavskii @michelengelen