[charts] Fix TS config #11259
Merged
[charts] Fix TS config #11259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
bug 🐛
|
Deploy preview: https://deploy-preview-11259--material-ui-x.netlify.app/ |
michelengelen
approved these changes
Nov 30, 2023
alexfauquette
added a commit
to alexfauquette/mui-x
that referenced
this pull request
Nov 30, 2023
alexfauquette
added a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Typescript config was merging multiple properties to add a new one. For most of them, it was ok since they were the same in the two interfaces. However, pie chart data was more complicated since the data array is completed during the defaultized process.
I simplified the config (first commit), and this reveald a small TS error (fixed in the second commit)
The remaining commits are script