[charts] Remove animation on sparkline #11311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: charts
|
Deploy preview: https://deploy-preview-11311--material-ui-x.netlify.app/ Updated pages: |
oliviertassinari
commented
Dec 5, 2023
| <BarChart skipAnimation /> | ||
| <BarChart skipAnimation /> |
There was a problem hiding this comment.
It displays funny https://next.mui.com/x/react-charts/bars/#animation
flaviendelangle
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the latest blog post about MUI X and landed on this strange demo experience: https://next.mui.com/x/react-data-grid/custom-columns/#sparkline.
Screen.Recording.2023-12-05.at.12.10.11.mov
None of the Sparklines in https://www.notion.so/mui-org/Sparkline-component-fc42c8576f7a4a46858fbcd713146072 have animations. I think animation is nice if you have a few charts, and you don't need to quickly scan the values, but if that's not the case, e.g. sparkling, it degrades the UX.
This is a polish on top of #9926.
After: https://deploy-preview-11311--material-ui-x.netlify.app/x/react-data-grid/custom-columns/#sparkline
Off-topic. We have no label per component type, is this missing? e.g. LineChart, BarChart, Sparkline, etc.