Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Fix views height consistency #11337

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 7, 2023

Extract 19b9cbd and 95c320a.

While working on integrating DateRangeCalendar and time clock in a two column layout for the Date Time Range picker I've noticed that there is an inconsistency in the calendar height, particularly the PickersCalendarHeader, which was 2px too short on regular DateCalendar.
The MD2 spec calls for a header height of 56px instead of the 54px, which we currently have.

Extracting the change into a separate PR to separate the Argos diff.

@LukasTy LukasTy added design: material This is about Material Design, please involve a visual or UX designer in the process component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature design This is about UI or UX design, please involve a designer labels Dec 7, 2023
@LukasTy LukasTy self-assigned this Dec 7, 2023
@mui-bot
Copy link

mui-bot commented Dec 7, 2023

Deploy preview: https://deploy-preview-11337--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3d339cb

@LukasTy LukasTy merged commit 9ee070f into mui:next Dec 8, 2023
21 checks passed
@LukasTy LukasTy deleted the fix-views-height branch December 8, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants