[pickers] Support name prop (#11025) #11380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
flaviendelangle
added
component: pickers
flaviendelangle
changed the title
|
Deploy preview: https://deploy-preview-11380--material-ui-x.netlify.app/ |
michelengelen
approved these changes
Dec 12, 2023
| @@ -123,7 +124,7 @@ export const useDesktopRangePicker = < | |||
| timezone, | |||
| autoFocus: autoFocus && !props.open, | |||
| ref: fieldContainerRef, | |||
| ...(fieldType === 'single-input' && { inputRef }), | |||
| ...(fieldType === 'single-input' && { inputRef, name }), | |||
There was a problem hiding this comment.
nit: i am wondering why this isn't throwing an error. The problem with the short fused is that if the value is falsey it will get returned. This can happen here, so you are basically trying to spread a boolean value. 🤷🏼
There was a problem hiding this comment.
Not related to this PR
But if you think the behavior is not safe, we can improve it in a follow up 👍
| @@ -3,7 +3,7 @@ | |||
| "propDescriptions": { | |||
| "ampm": "12h/24h view for hour selection clock.", | |||
| "autoFocus": "If <code>true</code>, the <code>input</code> element is focused during the first mount.", | |||
| "color": "The color of the component. It supports both default and custom theme colors, which can be added as shown in the <a href=\"https://mui.com/material-ui/customization/palette/#adding-new-colors\">palette customization guide</a>.", | |||
| "color": "The color of the component. It supports both default and custom theme colors, which can be added as shown in the <a href=\"https://mui.com/material-ui/customization/palette/#custom-colors\">palette customization guide</a>.", | |||
There was a problem hiding this comment.
nit: this change seems unrelated. If it was intentional 🆗
There was a problem hiding this comment.
It was intentional 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from #11025