Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve Pickers name prop examples #11422

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[docs] Improve Pickers name prop examples #11422

merged 1 commit into from
Dec 18, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 15, 2023

Follow-up on #11025

  • Use more form related name prop values;
  • Add name prop usage example on DateRangePicker example with single input field;
  • Add relevant components item to avoid layout issues;
    Screenshot 2023-12-15 at 14 15 49

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Dec 15, 2023
@LukasTy LukasTy self-assigned this Dec 15, 2023
@mui-bot
Copy link

mui-bot commented Dec 15, 2023

Deploy preview: https://deploy-preview-11422--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against c48b0ba

michelengelen
michelengelen approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

flaviendelangle
flaviendelangle approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make total sense to me, thanks for taking the time to polish those demos 👍

@LukasTy LukasTy added the needs cherry-pick The PR should be cherry-picked to master after merge label Dec 18, 2023
@LukasTy LukasTy merged commit d4e65d2 into mui:next Dec 18, 2023
20 checks passed
@LukasTy LukasTy deleted the fix-pickers-name-prop-doc branch December 18, 2023 09:01
LukasTy added a commit to LukasTy/mui-x that referenced this pull request Dec 18, 2023
@LukasTy
[docs] Improve Pickers name prop examples (mui#11422)
79f4bd6
@LukasTy LukasTy mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@michelengelen michelengelen michelengelen approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LukasTy @mui-bot @flaviendelangle @michelengelen