Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix cherry-pick action #11446

Merged
merged 3 commits into from
Dec 18, 2023
Merged

[core] Fix cherry-pick action #11446

merged 3 commits into from
Dec 18, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 18, 2023

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label Dec 18, 2023
@LukasTy LukasTy self-assigned this Dec 18, 2023
LukasTy
LukasTy commented Dec 18, 2023
View reviewed changes
.github/workflows/cherry-pick-next-to-master.yml
@@ -1,5 +1,5 @@
on:
pull_request:
pull_request_target:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/marketplace/actions/github-cherry-pick-action#working-with-forked-repositories
And also

mui-x/.github/workflows/maintenance.yml

Line 12 in cec51c5

pull_request_target:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I totally missed this part 😞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, all of us as well, because we approved your original PR. 🙈 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed, it worked with the new config and these settings:
image

Removing checkmark from Allow Github actions to create... makes it fail.

.github/workflows/cherry-pick-next-to-master.yml Show resolved Hide resolved
.github/workflows/cherry-pick-next-to-master.yml Outdated Show resolved Hide resolved
@mui-bot
Copy link

mui-bot commented Dec 18, 2023 •
edited

Deploy preview: https://deploy-preview-11446--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8b4266c

michelengelen
michelengelen approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... nice effort!

@LukasTy @MBilalShafi
Update .github/workflows/cherry-pick-next-to-master.yml
d32bf77 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Lukas <llukas.tyla@gmail.com>
MBilalShafi
MBilalShafi approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it.

@LukasTy
Copy link
Member Author

LukasTy commented Dec 18, 2023

Thank you for fixing it.

Thank you for the actual heavy-lifting—testing and the working proposal for the branch name! 🙏 🙇

@LukasTy LukasTy enabled auto-merge (squash) December 18, 2023 16:09
@LukasTy LukasTy merged commit ab6fb0e into mui:next Dec 18, 2023
15 checks passed
@LukasTy LukasTy deleted the fix-cherry-pick-action branch December 18, 2023 21:43
@oliviertassinari

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@michelengelen michelengelen michelengelen approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

@LukasTy LukasTy

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LukasTy @mui-bot @oliviertassinari @MBilalShafi @michelengelen