[charts] Make error message more explicit #11457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
component: charts
|
Deploy preview: https://deploy-preview-11457--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Dec 21, 2023
| @@ -97,22 +98,42 @@ const useCompletedData = (): CompletedBarData[] => { | |||
| if (verticalLayout) { | |||
| if (!isBandScaleConfig(xAxisConfig)) { | |||
| throw new Error( | |||
| `Axis with id "${xAxisKey}" shoud be of type "band" to display the bar series of id "${seriesId}"`, | |||
| `MUI-Charts: ${ | |||
There was a problem hiding this comment.
Nitpick: Have you considered going with a MUI-X-Charts prefix instead to be more explicit/correct? 🤔
There was a problem hiding this comment.
No, but it's a good idea :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvement the charts error message in 3 ways (one per commit):
MUI-Charts:to distinguish error messages that are charts from those coming from other MUI dependencies.Axis of id "DEFAULT_X_AXIS_KEY" should be ...which makes no sense for a new user.