[core] Remove PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD #11608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
1 task
oliviertassinari
changed the title
|
Deploy preview: https://deploy-preview-11608--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Jan 8, 2024
|
Core and Toolpad already took care of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Playwright v1.38.0, it does not download browsers automatically: https://github.com/microsoft/playwright/releases/tag/v1.38.0, so PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD is noise.
I found this by chance, I wanted to run the Karma tests for mui/material-ui#39981 and went down a deep rabbit hole as I was trying to make sense of a few strange things in the codebase.