[charts] Fix default stackOffset for LineChart
#11647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-11647--material-ui-x.netlify.app/ Updated pages: |
alexfauquette
added
the
needs cherry-pick
LukasTy
approved these changes
Jan 16, 2024
| [key in 'appearance' | 'ascending' | 'descending' | 'insideOut' | 'none' | 'reverse']: ( | ||
| series: Series<any, any>, | ||
| ) => number[]; | ||
| [key in StackOrderType]: (series: Series<any, any>) => number[]; |
There was a problem hiding this comment.
IMHO, this refactor makes code way cleaner. 👏 💯
LukasTy
changed the title
stackOffset for LineChart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue reported in https://discord.com/channels/1131323012554174485/1131329761952682114/1194552540294025256
I update don e of the demo to make sure it works properly when a value is 0.
Tltr: The default stacking strategy was "diverging" which staks all the positive values on top of each other and all the negative values below each over. For example values 1, -2, 3, -4 will render rectangles between:
The edge case being 0 which is always ploted at [0, 0]
As you can see in the image is does not work with area charts, because when a series has a 0, it moves to 0 instead of stacking on top of others