Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Add Croatian (hr-HR), Portuguese (pt-PT), and Chinese (Hong Kong) (zh-HK) locales #11668

Merged
merged 5 commits into from
Jan 17, 2024
Merged

[l10n] Add Croatian (hr-HR), Portuguese (pt-PT), and Chinese (Hong Kong) (zh-HK) locales #11668

merged 5 commits into from
Jan 17, 2024

Conversation

BCaspari
Copy link
Contributor

@mui-bot
Copy link

mui-bot commented Jan 12, 2024 •
edited

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Verify that you have added an export line in src/locales/index.ts for the new locale.
  • Run yarn docs:api which should add your new translation to the list of exported interfaces.
  • Clean files with yarn prettier.

Deploy preview: https://deploy-preview-11668--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5afe76e

@BCaspari BCaspari changed the title [l10n] added hr-HR, pt-PT and zh-HK translations for data grid [l10n] Add Croatian (hr-HR), Portuguese (pt-PT) and Chinese (Hong Kong) (zh-HK) locales Jan 12, 2024
@BCaspari
Copy link
Contributor Author

BCaspari commented Jan 12, 2024 •
edited

Unfortunately, yarn docs:api fails. What can I do to fix this?

... Built API docs for /x/api/charts/scatter-plot Built API docs for /x/api/charts/spark-line-chart Error: packages\x-charts\src\context\HighlightProvider.tsx: No exported component for the componentName "HighlightProvider" at extractClassesFromProps (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:137:11) at extractClasses (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:88:5) at parseSlotsAndClasses (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:69:28) at generateComponentApi (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\ApiBuilders\/ComponentApiBuilder.ts:748:50) at C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:147:16 at async Promise.allSettled (index 18) at buildSingleProject (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:173:18) at buildApi (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:82:27) Error: packages\x-charts\src\context\InteractionProvider.tsx: No exported component for the componentName "InteractionProvider" at extractClassesFromProps (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:137:11) at extractClasses (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:88:5) at parseSlotsAndClasses (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:69:28) at generateComponentApi (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\ApiBuilders\/ComponentApiBuilder.ts:748:50) at C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:147:16 at async Promise.allSettled (index 19) at buildSingleProject (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:173:18) at buildApi (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:82:27) Error: packages\x-charts\src\context\SeriesContextProvider.tsx: No exported component for the componentName "SeriesContextProvider" at extractClassesFromProps (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:137:11) at extractClasses (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:88:5) at parseSlotsAndClasses (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\utils\/parseSlotsAndClasses.ts:69:28) at generateComponentApi (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\ApiBuilders\/ComponentApiBuilder.ts:748:50) at C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:147:16 at async Promise.allSettled (index 20) at buildSingleProject (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:173:18) at buildApi (C:\repos\mui-x\node_modules\.pnpm\github.com+mui+material-ui@54e9b1365f7024e98ffc4a22dd69ce595110191a\node_modules\@mui\monorepo\packages\api-docs-builder\/buildApi.ts:82:27) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@zannager zannager added the l10n localization label Jan 12, 2024
@MBilalShafi MBilalShafi added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2024
@MBilalShafi MBilalShafi changed the title [l10n] Add Croatian (hr-HR), Portuguese (pt-PT) and Chinese (Hong Kong) (zh-HK) locales [l10n] Add Croatian (hr-HR), Portuguese (pt-PT), and Chinese (Hong Kong) (zh-HK) locales Jan 17, 2024
MBilalShafi
MBilalShafi approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

MBilalShafi
MBilalShafi reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand this change. Maybe keep it default if can't right now?

packages/grid/x-data-grid/src/locales/hrHR.ts Outdated Show resolved Hide resolved
packages/grid/x-data-grid/src/locales/ptPT.ts Outdated Show resolved Hide resolved
packages/grid/x-data-grid/src/locales/zhHK.ts Outdated Show resolved Hide resolved
@MBilalShafi MBilalShafi self-requested a review January 17, 2024 07:09
BCaspari and others added 4 commits January 17, 2024 08:22
@BCaspari @MBilalShafi
Update packages/grid/x-data-grid/src/locales/hrHR.ts
14f69ef 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: BCaspari <caspari@rossmanith.com>
@BCaspari @MBilalShafi
Update packages/grid/x-data-grid/src/locales/ptPT.ts
870d9e0 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: BCaspari <caspari@rossmanith.com>
@BCaspari @MBilalShafi
Update packages/grid/x-data-grid/src/locales/zhHK.ts
605a728 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: BCaspari <caspari@rossmanith.com>
@BCaspari
fixed columnHeaderFiltersTooltipActive translations
5afe76e
@BCaspari
Copy link
Contributor Author

You are right, I fixed the broken strings.

@MBilalShafi MBilalShafi added the needs cherry-pick The PR should be cherry-picked to master after merge label Jan 17, 2024
@MBilalShafi MBilalShafi merged commit 4e774be into mui:next Jan 17, 2024
18 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
@BCaspari @MBilalShafi @web-flow
[l10n] Add Croatian (hr-HR), Portuguese (pt-PT), and Chinese (Hong Ko…
ed7f1cb 
…ng) (zh-HK) locales (#11668)

Signed-off-by: BCaspari <caspari@rossmanith.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BCaspari @mui-bot @MBilalShafi @zannager