Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Remove a TS ignore #11688

Merged
merged 2 commits into from
Jan 16, 2024
Merged

[charts] Remove a TS ignore #11688

merged 2 commits into from
Jan 16, 2024

Conversation

alexfauquette
Copy link
Member

Using valueFormatter: (value: TValue) => string leads to valueFormatter: (value: BarValueType & LineValueType & PieValueType) => string when doing the union

Neest to use generic when defining function type

valueFormatter: <V extends TValue>(value: V) => string

Let me realised the bar charts did not have the typing for null which is weird

@alexfauquette alexfauquette added typescript component: charts This is the name of the generic UI component, not the React module! labels Jan 15, 2024
@mui-bot
Copy link

mui-bot commented Jan 15, 2024 •
edited

Deploy preview: https://deploy-preview-11688--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d20e8ef

@alexfauquette alexfauquette merged commit c74a24a into mui:next Jan 16, 2024
17 checks passed
@alexfauquette alexfauquette deleted the fix-tooltip-data branch January 16, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
component: charts This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfauquette @mui-bot @flaviendelangle