Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Introduce a new TreeItem2 component and a new useTreeItem2 hook #11721

Merged
merged 60 commits into from
Mar 11, 2024
Merged

[TreeView] Introduce a new TreeItem2 component and a new useTreeItem2 hook #11721

merged 60 commits into from
Mar 11, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 17, 2024 •
edited

Closes #12287
Fixes #12284

Waiting for #12231 to have a coherent "RichTreeView - Customization" doc page

@flaviendelangle flaviendelangle self-assigned this Jan 17, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jan 17, 2024
@flaviendelangle flaviendelangle changed the title [TreeView] New hook useTreeItem [TreeView] New hook useTreeItem Jan 17, 2024
@mui-bot
Copy link

mui-bot commented Jan 17, 2024 •
edited

Deploy preview: https://deploy-preview-11721--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 83ecbea

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 19, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 22, 2024
flaviendelangle
flaviendelangle commented Feb 15, 2024
View reviewed changes
docs/data/tree-view/simple-tree-view/customization/IconExpansionTreeView.js
@@ -1,76 +1,37 @@
import * as React from 'react';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I migrated this example to the new API to give an example of what it would look like

BUT we should not merge it like this, we should keep the old example until the new API is public

flaviendelangle
flaviendelangle commented Feb 15, 2024
View reviewed changes
docs/data/tree-view/simple-tree-view/customization/CustomContentTreeView.tsx
@@ -1,93 +1,72 @@
import * as React from 'react';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I migrated this example to the new API to give an example of what it would look like

BUT we should not merge it like this, we should keep the old example until the new API is public

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way cleaner! 💙

@flaviendelangle flaviendelangle changed the title [TreeView] New hook useTreeItem [TreeView] Introduce a new TreeItem2 component and a new useTreeItem2 hook Mar 5, 2024
@flaviendelangle flaviendelangle mentioned this pull request Mar 5, 2024
Merged
@LukasTy LukasTy added the new feature New feature or request label Mar 5, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 6, 2024
LukasTy
LukasTy reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏
Leaving a bit of mostly nitpick comments. 🙈

docs/data/tree-view/rich-tree-view/customization/LabelSlots.tsx Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/customization/LabelSlots.tsx Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/customization/LabelSlots.tsx Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/customization/LabelSlots.tsx Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/customization/customization.md Outdated Show resolved Hide resolved
packages/x-tree-view/src/useTreeItem2/useTreeItem2.types.ts Outdated Show resolved Hide resolved
packages/x-tree-view/src/useTreeItem2/useTreeItem2.types.ts Outdated Show resolved Hide resolved
packages/x-tree-view/src/useTreeItem2/useTreeItem2.types.ts Outdated Show resolved Hide resolved
packages/x-tree-view/src/useTreeItem2/useTreeItem2.types.ts Outdated Show resolved Hide resolved
scripts/x-tree-view.exports.json Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle marked this pull request as ready for review March 7, 2024 09:44
LukasTy
LukasTy approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! 👏 💯

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 11, 2024
@flaviendelangle flaviendelangle merged commit b8566a0 into mui:next Mar 11, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the headless-tree-item branch March 11, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@flaviendelangle @mui-bot @michaldudak @LukasTy @alexfauquette