[DataGrid] Fix values labels in is any of filter operator
#11939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11939--material-ui-x.netlify.app/ |
michelengelen
added
component: data grid
michelengelen
changed the title
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
|
@cherniavskii This PR is ready for review |
|
@MBilalShafi adding you as reviewer since @cherniavskii is OOO |
michelengelen
requested review from
MBilalShafi
and removed request for
cherniavskii
MBilalShafi
approved these changes
Feb 15, 2024
| resolvedValueOptions?.find((resolvedValue) => getOptionValue(resolvedValue) === value), | ||
| ) | ||
| .filter((value) => value !== undefined) as ValueOptions[]; | ||
| }, [getOptionValue, item.value, resolvedValueOptions]); |
There was a problem hiding this comment.
Maybe do in one go?
diff --git a/packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx b/packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx
index 517860549..1d274b335 100644
--- a/packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx
+++ b/packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx
@@ -79,11 +79,15 @@ function GridFilterInputMultipleSingleSelect(props: GridFilterInputMultipleSingl
return [];
}
- return item.value
- ?.map((value) =>
- resolvedValueOptions?.find((resolvedValue) => getOptionValue(resolvedValue) === value),
- )
- .filter((value) => value !== undefined) as ValueOptions[];
+ return item.value.reduce<ValueOptions[]>((acc, value) => {
+ const resolvedValue = resolvedValueOptions.find(
+ (v) => getOptionValue(v) === value,
+ );
+ if (resolvedValue != null) {
+ acc.push(resolvedValue);
+ }
+ return acc;
+ }, [] as ValueOptions[]);
}, [getOptionValue, item.value, resolvedValueOptions]);
const handleChange = React.useCallback<There was a problem hiding this comment.
The adjustment has been made @MBilalShafi, thanks for the review.
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com> Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
michelengelen
approved these changes
Feb 19, 2024
|
Thanks @gitstart 🙇🏼 |
cherniavskii
changed the title
is any of filter operator
cherniavskii
changed the title
is any of filter operatoris any of filter operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SIngleSelect columns now displays label property instead of value property
Closes 11755
Refs
Loom Video
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.