[charts] Support UTC date formatting in tooltip #11943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11943--material-ui-x.netlify.app/ |
alexfauquette
added
the
component: charts
packages/x-charts/src/ChartsTooltip/DefaultChartsAxisTooltipContent.tsx
Outdated
Show resolved
Hide resolved
packages/x-charts/src/ChartsTooltip/DefaultChartsAxisTooltipContent.tsx
Outdated
Show resolved
Hide resolved
packages/x-charts/src/ChartsTooltip/DefaultChartsAxisTooltipContent.tsx
Outdated
Show resolved
Hide resolved
| @@ -18,7 +18,18 @@ function DefaultChartsAxisTooltipContent(props: ChartsAxisContentProps) { | |||
| if (dataIndex == null) { | |||
| return null; | |||
| } | |||
| const axisFormatter = axis.valueFormatter ?? ((v) => v.toLocaleString()); | |||
|
|
|||
| const utcFormatter = (v: string | number | Date): string => { | |||
There was a problem hiding this comment.
The value can also be null. Maybe we can move this function definition outside of the component since it does not require any prop
There was a problem hiding this comment.
if you check the previous implementation null case of v was not considered
There was a problem hiding this comment.
Effectively, I forgot this axisValue != null && !axis.hideTooltip condition
alexfauquette
approved these changes
Feb 6, 2024
alexfauquette
added
the
needs cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11787
previous
now