Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Bump monorepo #12001

Merged
merged 6 commits into from Feb 9, 2024
Merged

[core] Bump monorepo #12001

merged 6 commits into from Feb 9, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Feb 8, 2024 •
edited

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Feb 8, 2024
@cherniavskii cherniavskii mentioned this pull request Feb 8, 2024
Merged
@mui-bot
Copy link

mui-bot commented Feb 8, 2024 •
edited

Deploy preview: https://deploy-preview-12001--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 965e47c

@cherniavskii cherniavskii marked this pull request as ready for review February 8, 2024 19:08
alexfauquette
alexfauquette approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Do you think it's possible to backport it to master? Or do we rely on the 301 redirection of the core?

docs/data/charts/getting-started/getting-started.md
@@ -78,7 +78,7 @@ pnpm add @mui/styled-engine-sc styled-components

</codeblock>

Take a look at the [Styled engine guide](/material-ui/guides/styled-components/) for more information about how to configure `styled-components` as the style engine.
Take a look at the [Styled engine guide](/material-ui/integrations/styled-components/) for more information about how to configure `styled-components` as the style engine.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's the docs:link-check that asked for that 😍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I could've added them to .link-check-errors because most of them have redirects, but decided to update the links instead.

@cherniavskii
Copy link
Member Author

Do you think it's possible to backport it to master?

I think this should be doable. Is there a reason to do so? 🙂

Or do we rely on the 301 redirection of the core?

Which redirects do you mean?

@cherniavskii cherniavskii merged commit 300d079 into mui:next Feb 9, 2024
17 checks passed
@cherniavskii cherniavskii deleted the bump-monorepo branch February 9, 2024 12:06
@alexfauquette
Copy link
Member

Which redirects do you mean?

I'm thinking about those guides to integrations urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cherniavskii @mui-bot @alexfauquette