Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7.0.0-beta.2 #12014

Merged
merged 14 commits into from Feb 9, 2024
Merged

v7.0.0-beta.2 #12014

merged 14 commits into from Feb 9, 2024

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Feb 9, 2024

No description provided.

DanailH and others added 7 commits February 9, 2024 15:38
@DanailH
v7.0.0-beta.1
18edb01
@DanailH
update versions
f81582f
@DanailH
fix lint error
ee1eadd
@DanailH @flaviendelangle @LukasTy
Apply suggestions from code review
7f194ce 
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH @MBilalShafi
Update CHANGELOG.md
9bd4ab0 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH
get latest
a17de0d
@DanailH
Merge branch 'new/7.0.0-beta.1' of https://github.com/mui/mui-x into …
4a515f6 
…new/7.0.0-beta.1
@DanailH DanailH changed the title v7.0.0 beta.1 v7.0.0 beta.2 Feb 9, 2024
@DanailH DanailH requested a review from a team February 9, 2024 14:06
@DanailH DanailH self-assigned this Feb 9, 2024
@DanailH DanailH added the release We are shipping :D label Feb 9, 2024
@mui-bot
Copy link

mui-bot commented Feb 9, 2024 •
edited

Deploy preview: https://deploy-preview-12014--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 43b5220

LukasTy
LukasTy reviewed Feb 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
packages/x-data-grid-premium/package.json Outdated Show resolved Hide resolved
packages/x-data-grid-pro/package.json Outdated Show resolved Hide resolved
packages/x-date-pickers-pro/package.json Outdated Show resolved Hide resolved
packages/x-license/package.json Outdated Show resolved Hide resolved
packages/x-tree-view/package.json Outdated Show resolved Hide resolved
alexfauquette
alexfauquette approved these changes Feb 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
DanailH and others added 2 commits February 9, 2024 17:52
@DanailH @alexfauquette
Update CHANGELOG.md
6e39662 
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH @LukasTy
Apply suggestions from code review
13b9ea4 
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH
Copy link
Member Author

DanailH commented Feb 9, 2024

@LukasTy do the versions need to be aligned? They are not currently in sync and either way, the license package is almost never updated and the treeview did not have any changes in the last release.

@LukasTy
Copy link
Member

LukasTy commented Feb 9, 2024

do the versions need to be aligned? They are not currently in sync and either way, the license package is almost never updated and the treeview did not have any changes in the last release.

They don't HAVE to be aligned, it's just a practice that we've been doing most of the time.
We really need to discuss this matter, take a decision, and stick to it. 🙈

@DanailH @LukasTy
Apply suggestions from code review
cb46fc7 
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@DanailH
Copy link
Member Author

DanailH commented Feb 9, 2024

Idk what changed but before if the package was not changed we did not bump the version (with some exceptions like the grid packages and the pickers). Either way, I synced the versions but it's good to be consistent because now we are skipping versions.

@flaviendelangle
Copy link
Member

My understanding was the same as Danail
All packages of a product line are always synced (@mui/x-data-grid should ALWAYS have the same version as @mui/x-data-grid-pro)
But if a product line receives no change, we don't release it.

I do agree that it would be nice to align once and for all on this topic, feel like we are talking about it every 2 weeks
@DanailH ok to discuss it on our next general tag up next week?

@DanailH DanailH merged commit 0625170 into mui:next Feb 9, 2024
17 checks passed
@DanailH DanailH changed the title v7.0.0 beta.2 v7.0.0-beta.2 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle left review comments

@LukasTy LukasTy LukasTy left review comments

@cherniavskii cherniavskii cherniavskii left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@DanailH DanailH

Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DanailH @mui-bot @LukasTy @flaviendelangle @cherniavskii @alexfauquette