Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move Heat map to pro #12047

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[docs] Move Heat map to pro #12047

merged 2 commits into from
Feb 22, 2024

Conversation

alexfauquette
Copy link
Member

@joserodolfofreitas Do you see other modification?

@alexfauquette alexfauquette added docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge component: charts This is the name of the generic UI component, not the React module! labels Feb 13, 2024
@mui-bot
Copy link

mui-bot commented Feb 13, 2024

Deploy preview: https://deploy-preview-12047--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against b3563dd

@oliviertassinari oliviertassinari changed the title [docs] Move heatmap to pro [docs] Move Heat map to pro Feb 13, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 13, 2024

Right, Chart.js nor Recharts having Heat map makes a solid case to do this move, we can always change this later on.

Side question, if we do this move with Heat map, then why not Tree map as well?

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 13, 2024
@alexfauquette
Copy link
Member Author

Side question, if we do this move with Heat map, then why not Tree map as well?

Because Recharts has a basic tree map

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 20, 2024
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexfauquette!

@alexfauquette alexfauquette merged commit d98caba into mui:next Feb 22, 2024
17 checks passed
@alexfauquette alexfauquette deleted the pricing branch February 22, 2024 12:36
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
oliviertassinari added a commit that referenced this pull request Feb 22, 2024
oliviertassinari added a commit that referenced this pull request Feb 22, 2024
@oliviertassinari
Copy link
Member

We missed a small one: https://mui.com/x/react-charts/#all-mui-x-charts-components.

SCR-20240222-tmiz

Fixed in 71b34fd.

SCR-20240222-trpq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants