Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Removed focused prop from demo #12092

Merged
merged 1 commit into from Feb 16, 2024
Merged

[docs] Removed focused prop from demo #12092

merged 1 commit into from Feb 16, 2024

Conversation

michelengelen
Copy link
Member

Fixes #12018

@michelengelen michelengelen self-assigned this Feb 16, 2024
@michelengelen michelengelen added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Feb 16, 2024
@mui-bot
Copy link

mui-bot commented Feb 16, 2024

Deploy preview: https://deploy-preview-12092--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 99d03be

LukasTy
LukasTy approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 👍
Thanks for cleaning it up. 💙
Do you think it makes sense to cherry-pick it to master (v6) - probably without the value instance checking removal? 🤔

@michelengelen michelengelen merged commit 7817838 into mui:next Feb 16, 2024
19 of 20 checks passed
@michelengelen michelengelen deleted the docs/12018-remove-focused-prop branch February 16, 2024 11:22
michelengelen added a commit to michelengelen/mui-x that referenced this pull request Feb 19, 2024
@michelengelen
added change from mui#12092 without the value type checks
6db2e18
@michelengelen michelengelen mentioned this pull request Feb 19, 2024
Merged
1 task
michelengelen added a commit that referenced this pull request Feb 19, 2024
@michelengelen
[docs] cherry pick of #12092 (#12126)
48556d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees

@michelengelen michelengelen

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
3 participants
@michelengelen @mui-bot @LukasTy