[core] Simplify key utils #12120
Merged
[core] Simplify key utils #12120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
deprecate-old-utils
branch
from
81f62bd
to
95c3c82
Compare
| } else if (event.key === 'Delete' || event.key === 'Backspace') { | ||
| // Delete on Windows, Backspace on macOS | ||
| } else if (event.key === 'Backspace' || event.key === 'Delete') { |
There was a problem hiding this comment.
Backspace is a lot more likely to be used than Delete, see https://en.wikipedia.org/wiki/Delete_key it's hard to reach on Windows keyboard layouts and doesn't exist on Mac.
|
Deploy preview: https://deploy-preview-12120--material-ui-x.netlify.app/ |
romgrk
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helpers look like noise. I didn't remove them all to save time, but at least wanted to help make a step toward removing them.
I saw this in #11965.