Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Stop using custom findIndex to support IE11 #12129

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[TreeView] Stop using custom findIndex to support IE11 #12129

merged 1 commit into from
Feb 19, 2024

Conversation

flaviendelangle
Copy link
Member

Follow up on #12119

@flaviendelangle flaviendelangle self-assigned this Feb 19, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Feb 19, 2024
@mui-bot
Copy link

mui-bot commented Feb 19, 2024

Deploy preview: https://deploy-preview-12129--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b10fe43

@flaviendelangle flaviendelangle changed the title [TreeView] Stop using custom findIndex to support IE11 [TreeView] Stop using custom findIndex to support IE11 Feb 19, 2024
@oliviertassinari
Copy link
Member

It makes me wonder if the Tree View can't replace DescendantProvider with Base UI's useCompound.

michelengelen
michelengelen approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noraleonte
noraleonte approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@flaviendelangle
Copy link
Member Author

It makes me wonder if the Tree View can't replace DescendantProvider with Base UI's useCompound.

Would be awesome to be able to share this kind of logic
I'll have a look when I got some time, note that it's only used by SimpleTreeView, for RichTreeView we have all the data at the top level so no need for these registration mechanisms.

@flaviendelangle flaviendelangle merged commit 6179f3f into mui:next Feb 19, 2024
17 of 18 checks passed
@flaviendelangle flaviendelangle deleted the IE11-polyfill branch February 19, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@noraleonte noraleonte noraleonte approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flaviendelangle @mui-bot @oliviertassinari @michelengelen @noraleonte