Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Create local wrapper over describeConformance #12130

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Feb 19, 2024

Core's mui/material-ui#41175 removes test-utils dependency on @mui/material. With this change, the default ThemeProvider and createTheme are not provided and must be passed in by the caller. This change wraps the describeConformance so it's not needed to provide these fields in each describeConformance call.

This PR integrates the latest master from the Core monorepo.

@michaldudak michaldudak added core Infrastructure work going on behind the scenes test labels Feb 19, 2024
@mui-bot
Copy link

mui-bot commented Feb 19, 2024

Deploy preview: https://deploy-preview-12130--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9be2cb8

@michaldudak michaldudak marked this pull request as ready for review February 20, 2024 07:37
@michaldudak michaldudak requested a review from a team February 20, 2024 07:37
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving one question. 😉

P.S. Please sync with the latest next to resolve the docs:link-check error. 😉

@Janpot
Copy link
Member

Janpot commented Feb 20, 2024

Looks like this is now blocking #11880

@michaldudak michaldudak merged commit a609b12 into mui:next Feb 20, 2024
17 checks passed
@michaldudak michaldudak deleted the core-integration/41175 branch February 20, 2024 13:27
@michaldudak
Copy link
Member Author

@Janpot you should be able to rebase now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants