Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix "Licensing" page link #12156

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[docs] Fix "Licensing" page link #12156

merged 2 commits into from
Feb 22, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 21, 2024

Address docs feedback:

The "the relevant clause in the EULA." link doesn't jump to the intended section; it should now link to https://mui.com/legal/mui-x-eula/#2-5-required-quantity-of-licenses
sent from https://mui.com/x/introduction/licensing/#how-many-developer-seats-do-i-need (from section How many developer seats do I need?)

@LukasTy LukasTy added the docs Improvements or additions to the documentation label Feb 21, 2024
@LukasTy LukasTy self-assigned this Feb 21, 2024
LukasTy
LukasTy commented Feb 21, 2024
View reviewed changes
docs/data/introduction/licensing/licensing.md
@@ -296,7 +296,7 @@ This error indicates that your MUI X license key format isn't valid.
It could be because the license key is missing a character or has a typo.

To solve the issue, you need to double-check that `setLicenseKey()` is called with the right argument.
Please check the [license key installation](#license-key-installation).
Please check the [license key installation](/x/introduction/licensing/#license-key).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to full relative URL to benefit from docs:link-check.

@mui-bot
Copy link

mui-bot commented Feb 21, 2024 •
edited

Deploy preview: https://deploy-preview-12156--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against e7a3d05

@LukasTy LukasTy added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 21, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 21, 2024 •
edited

Address docs feedback:

This is a regression from https://github.com/mui/mui-private/pull/339 cc @hasdfa. I have opened https://github.com/mui/mui-private/issues/404. There are broken links on MUI Core, MUI X (there are more in this repo) and MUI Private repos.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse labels Feb 21, 2024
@oliviertassinari oliviertassinari changed the title [docs] Update "Licensing" page links [docs] Fix "Licensing" page links Feb 21, 2024
flaviendelangle
flaviendelangle approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Unless you think @oliviertassinari need to approve explicitly, it would be nice to have it in today's release

@LukasTy
Copy link
Member Author

LukasTy commented Feb 22, 2024 •
edited

Looks good

Given the https://github.com/mui/mui-private/pull/405 it seems that the current solution will not be correct. 🤔
I'm not sure this is such a high priority issue to rush a partial/unstable fix. 🙈

@LukasTy
Apply suggestions from code review
e7a3d05 
Signed-off-by: Lukas <llukas.tyla@gmail.com>
@LukasTy LukasTy changed the title [docs] Fix "Licensing" page links [docs] Fix "Licensing" page link Feb 22, 2024
@LukasTy LukasTy removed regression A bug, but worse needs cherry-pick The PR should be cherry-picked to master after merge labels Feb 22, 2024
@LukasTy
Copy link
Member Author

LukasTy commented Feb 22, 2024

Removed the needs cherry-pick label as this issue is present only on next.
On master the section heading in question has not been renamed.

@LukasTy LukasTy enabled auto-merge (squash) February 22, 2024 15:55
@LukasTy LukasTy merged commit c150a85 into mui:next Feb 22, 2024
17 checks passed
@LukasTy LukasTy deleted the fix-docs-link branch February 22, 2024 16:10
@oliviertassinari
Copy link
Member

Perfect, it looks all correct 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joserodolfofreitas joserodolfofreitas joserodolfofreitas left review comments

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees

@LukasTy LukasTy

Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LukasTy @mui-bot @oliviertassinari @joserodolfofreitas @flaviendelangle