Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix wrong offset for right-pinned columns when toggling dark/light modes #12233

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[DataGrid] Fix wrong offset for right-pinned columns when toggling dark/light modes #12233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/x-data-grid/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export interface GetHeadersParams {

const SpaceFiller = styled('div')({
/* GridRootStyles conflict */
'&&': {
'&&&': {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but style order changes on color mode change, and && is not sufficient anymore:

Screen.Recording.2024-02-27.at.18.51.53.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's annoying

padding: 0,
width: 'calc(var(--DataGrid-width) - var(--DataGrid-columnsTotalWidth))',
},
Expand Down