Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Customize tick position for band scale #12316

Merged
merged 7 commits into from
Mar 7, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Mar 4, 2024

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Mar 4, 2024
@mui-bot
Copy link

mui-bot commented Mar 4, 2024

Deploy preview: https://deploy-preview-12316--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against b2eb20a

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only doc / JSDoc nitpicks 👍

docs/data/charts/bars/bars.md Outdated Show resolved Hide resolved
docs/data/charts/bars/bars.md Outdated Show resolved Hide resolved
docs/data/charts/bars/bars.md Outdated Show resolved Hide resolved
packages/x-charts/src/ChartsXAxis/ChartsXAxis.tsx Outdated Show resolved Hide resolved
alexfauquette and others added 3 commits March 7, 2024 10:27
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 🚀 💙

docs/data/charts/bars/bars.md Outdated Show resolved Hide resolved
docs/data/charts/bars/bars.md Outdated Show resolved Hide resolved
docs/data/charts/bars/TickPlacementBars.tsx Outdated Show resolved Hide resolved
docs/data/charts/bars/TickPlacementBars.tsx Outdated Show resolved Hide resolved
docs/data/charts/bars/TickPlacementBars.tsx Outdated Show resolved Hide resolved
docs/data/charts/bars/TickPlacementBars.tsx Outdated Show resolved Hide resolved
packages/x-charts/src/hooks/useTicks.ts Outdated Show resolved Hide resolved
@LukasTy LukasTy added the new feature New feature or request label Mar 7, 2024
@alexfauquette alexfauquette enabled auto-merge (squash) March 7, 2024 11:14
@alexfauquette alexfauquette merged commit 4e5c087 into mui:next Mar 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] Is there a non 'band' scale type layout for bar charts?
4 participants