Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix cell value formatting on copy #12357

Merged
merged 6 commits into from Mar 18, 2024
Merged

[DataGrid] Fix cell value formatting on copy #12357

merged 6 commits into from Mar 18, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 7, 2024 •
edited

@sai6855 sai6855 marked this pull request as draft March 7, 2024 05:41
@sai6855 sai6855 added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Clipboard Related to clipboard copy or paste functionalities labels Mar 7, 2024
@mui-bot
Copy link

mui-bot commented Mar 7, 2024 •
edited

Deploy preview: https://deploy-preview-12357--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8edc5fb

@sai6855 sai6855 marked this pull request as ready for review March 7, 2024 07:28
@sai6855 sai6855 requested a review from romgrk March 7, 2024 07:28
@sai6855 sai6855 force-pushed the issue-11945 branch 2 times, most recently from 7276569 to 8c2c8de Compare March 7, 2024 10:16
@sai6855 sai6855 changed the title [data-grid] Fix CSV cell value sanitization [data-grid] Fix cell value formatting on copy Mar 7, 2024
@romgrk romgrk requested review from cherniavskii and removed request for romgrk March 7, 2024 12:07
@sai6855 sai6855 changed the title [data-grid] Fix cell value formatting on copy [DataGrid] Fix cell value formatting on copy Mar 7, 2024
@sai6855 sai6855 mentioned this pull request Mar 15, 2024
Closed
cherniavskii
cherniavskii approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cherniavskii cherniavskii added needs cherry-pick The PR should be cherry-picked to master after merge CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 labels Mar 18, 2024
@cherniavskii cherniavskii changed the title [DataGrid] Fix cell value formatting on copy [DataGrid] Fix multi-line cell value formatting on copy Mar 18, 2024
@cherniavskii cherniavskii changed the title [DataGrid] Fix multi-line cell value formatting on copy [DataGrid] Fix cell value formatting on copy Mar 18, 2024
@cherniavskii cherniavskii enabled auto-merge (squash) March 18, 2024 17:37
@cherniavskii cherniavskii merged commit 5342203 into mui:next Mar 18, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 18, 2024
@sai6855 @cherniavskii @web-flow
[DataGrid] Fix cell value formatting on copy (#12357)
4a35a5d 
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Merged
@sai6855 sai6855 deleted the issue-11945 branch March 18, 2024 17:57
@MBilalShafi MBilalShafi mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 component: data grid This is the name of the generic UI component, not the React module! feature: Clipboard Related to clipboard copy or paste functionalities needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Multiline gets pasted with double quotes
3 participants
@sai6855 @mui-bot @cherniavskii