Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Fix axis highlight when axis is reversed #12407

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Mar 11, 2024

Fix #12371

I updated the demo to have the popper and the grid. It feels a bit more like a real charts

@alexfauquette alexfauquette added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! labels Mar 11, 2024
@alexfauquette alexfauquette changed the title [charts] Fix axis highlight with axis revert [charts] Fix axis highlight when axis is reverted Mar 11, 2024
@mui-bot
Copy link

mui-bot commented Mar 11, 2024

Deploy preview: https://deploy-preview-12407--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fd673e1

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore ... LGTM!

packages/x-charts/src/hooks/useAxisEvents.ts Outdated Show resolved Hide resolved
@LukasTy LukasTy changed the title [charts] Fix axis highlight when axis is reverted [charts] Fix axis highlight when axis is reversed Mar 11, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alexfauquette and others added 3 commits March 11, 2024 17:43
Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@alexfauquette alexfauquette merged commit ba66f90 into mui:next Mar 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] Tooltip displays the wrong information when the x-axis is reversed
4 participants