[TreeView] Do not use outdated version of the state to compute new label first char in RichTreeView
#12512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abel first char in RichTreeView
flaviendelangle
added
bug 🐛
flaviendelangle
changed the title
RichTreeView
|
Deploy preview: https://deploy-preview-12512--material-ui-x.netlify.app/ |
flaviendelangle
commented
Mar 20, 2024
| ); | ||
| if (itemElement) { | ||
| itemElement.blur(); | ||
| if (node) { |
There was a problem hiding this comment.
Not directly related but I noticed this bug while writing the tests.
If we remove the currently focused item from props.items, then its TreeItem while call removeFocusedItem, but the state does not contain the item anymore so it crashes.
flaviendelangle
changed the title
RichTreeViewRichTreeView
flaviendelangle
commented
Mar 20, 2024
| }; | ||
|
|
||
| params.items.forEach(processItem); | ||
| Object.values(state.nodes.nodeMap).forEach(processItem); |
There was a problem hiding this comment.
Btw this will support stuff like apiRef.current.updateItem when we add this kind of API, the previous approach did not.
It's still far from perfect because we loop through the whole dataset, but until we actually have partial dataset update it's good enough.
noraleonte
approved these changes
Mar 25, 2024
packages/x-tree-view/src/internals/plugins/useTreeViewNodes/useTreeViewNodes.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12510