Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix RTL mode #12583

Merged
merged 5 commits into from Mar 29, 2024
Merged

[DataGrid] Fix RTL mode #12583

merged 5 commits into from Mar 29, 2024

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Mar 27, 2024

Closes #12438

Make RTL work again.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Mar 27, 2024
@mui-bot
Copy link

mui-bot commented Mar 27, 2024

Deploy preview: https://deploy-preview-12583--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 880a067

@romgrk romgrk marked this pull request as draft March 27, 2024 18:45
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only reliable way to catch virtualization regressions, our usual tests are too tied to the HTML/CSS and not enough to the rendering part.

image

@romgrk romgrk marked this pull request as ready for review March 28, 2024 09:38
test/regressions/index.js Show resolved Hide resolved
@romgrk romgrk merged commit 5cbb056 into mui:master Mar 29, 2024
17 checks passed
@romgrk romgrk deleted the fix-grid-rtl branch March 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Broken horizontal scroll in RTL mode
3 participants