[docs] Make the Charts margin usage more visible
#12591
Conversation
alexfauquette
added
docs
|
Deploy preview: https://deploy-preview-12591--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Nice addition! 👏
Nitpick: Have you considered adding a toggle to the added demo to display the problem without the necessary tweaks? Basically, to allow users to better visualize what the applied changes fix. 🤔
P.S. I took the liberty to update the PR prefix to docs instead of charts as it doesn't impact the package itself. 🤔
LukasTy
changed the title
margin usage more visiblemargin usage more visible
| ); | ||
| } | ||
|
|
||
| const usAirportPassengers = [ |
There was a problem hiding this comment.
nitpick: as this package grows and the demos get more we should think about extracting demo data to a function as in the grid (useDemoData). WDYT?
There was a problem hiding this comment.
It's planed for real world data.
But I expect using the mui/material-ui#40901 instead of a package,
Co-authored-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Fix #12551