Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Fix readOnly behavior #12609

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[fields] Fix readOnly behavior #12609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a5456c
[fields] Fix `readOnly` behavior
LukasTy Mar 29, 2024
af008cf
Clear code
LukasTy Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/x-date-pickers/src/internals/hooks/useField/useFieldV6TextField.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ export const useFieldV6TextField: UseFieldTextField<false> = (params) => {
getActiveSectionIndexFromDOM: () => {
const browserStartIndex = inputRef.current!.selectionStart ?? 0;
const browserEndIndex = inputRef.current!.selectionEnd ?? 0;
if (browserStartIndex === 0 && browserEndIndex === 0) {
const isInputReadOnly = !!inputRef.current?.readOnly;
if ((browserStartIndex === 0 && browserEndIndex === 0) || isInputReadOnly) {
return null;
}

Expand All @@ -196,6 +197,7 @@ export const useFieldV6TextField: UseFieldTextField<false> = (params) => {

const syncSelectionFromDOM = () => {
if (readOnly) {
setSelectedSections(null);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert https://github.com/mui/mui-x/pull/12593/files#diff-c8baae3f915827c7c3a382b1b2e21197c74844d930c08a95a68f39f9e277da77L192 in favor of a more isolated fix above.

return;
}
const browserStartIndex = inputRef.current!.selectionStart ?? 0;
Expand Down