Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Create RichTreeViewPro component #12610

Merged
merged 16 commits into from Apr 4, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Mar 29, 2024

Follow up on #12240

@flaviendelangle flaviendelangle self-assigned this Mar 29, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Mar 29, 2024
@flaviendelangle flaviendelangle changed the title [TreeView] Create RichTreeViewPro component [TreeView] Create RichTreeViewPro component Mar 29, 2024
@mui-bot
Copy link

mui-bot commented Mar 29, 2024

Deploy preview: https://deploy-preview-12610--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 29e7e90

@flaviendelangle flaviendelangle marked this pull request as ready for review April 3, 2024 12:49
@@ -36,6 +36,7 @@ export const SimpleTreeViewRoot = styled('ul', {
margin: 0,
listStyle: 'none',
outline: 0,
position: 'relative',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this for the RichTreeViewPro otherwise the watermark is placed outside of the component.
I added it to RichTreeView and SimpleTreeView as well for consistency.

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
The only thing to consider is the themeAugmentation. 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding this project to the createXTypeScriptProjects list to track the exports evolution? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would add the interfaces to the doc
We could add a "private" option (or check the package.json) to only generate the exports file, I do agree it would be useful.

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Apr 3, 2024

The only thing to consider is the themeAugmentation

I forgot to add it 😬

EDIT: Done

@flaviendelangle flaviendelangle merged commit fdffa6a into mui:master Apr 4, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the create-RichTreeViewPro branch April 4, 2024 08:43
@@ -0,0 +1 @@
// Prefer to use `import type {} from '@mui/x-tree-view/themeAugmentation';` instead to avoid importing an empty file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick:

- @mui/x-tree-view/themeAugmentation
+ @mui/x-tree-view-pro/themeAugmentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants