[TreeView] Return instance
and publicAPI
methods from plugin and populate the main objects inside useTreeView
#12650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a DX change on the plugin API.
Right now, we are populating the
instance
andpublicAPI
objects inside each plugin using thepopulateInstance
andpopulatePublicAPI
methods.This PR proposes to instead have the plugin returning them and
useTreeView
do the population.Advantages
contextValue
which is returned by each plugininstance
orpublicAPI
instance
no longer need to access this parameterpublicAPI
parameter can be totally removed from the plugin parameters