Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Clean up usage of term node in internals #12655

Merged
merged 7 commits into from Apr 8, 2024
Merged

[TreeView] Clean up usage of term node in internals #12655

merged 7 commits into from Apr 8, 2024

Conversation

noraleonte
Copy link
Contributor

nodeMap → itemMetaMap

nodeTree → itemTree

getNode → getItemMeta

@noraleonte noraleonte added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Apr 3, 2024
@noraleonte noraleonte self-assigned this Apr 3, 2024
@mui-bot
Copy link

mui-bot commented Apr 3, 2024 •
edited

Deploy preview: https://deploy-preview-12655--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against e5830b5

flaviendelangle
flaviendelangle reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

packages/x-tree-view/src/internals/plugins/useTreeViewExpansion/useTreeViewExpansion.ts Outdated Show resolved Hide resolved
flaviendelangle
flaviendelangle approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of it!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 8, 2024
@noraleonte noraleonte merged commit 616cf32 into mui:master Apr 8, 2024
17 checks passed
@noraleonte noraleonte deleted the clean-up-usage-of-node branch April 8, 2024 17:37
@mnathsnyk mnathsnyk mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

@noraleonte noraleonte

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noraleonte @mui-bot @flaviendelangle