Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix ColDefChangesGridNoSnap demo crash #12663

Merged
merged 2 commits into from Apr 4, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Apr 3, 2024

Fixes #12628

No need to allow column menu operations on this demo, since this is mostly meant for informational purposes

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Apr 3, 2024
@mui-bot
Copy link

mui-bot commented Apr 3, 2024

Deploy preview: https://deploy-preview-12663--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0681032

@MBilalShafi MBilalShafi marked this pull request as ready for review April 3, 2024 18:29
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I understand this PR

image

@MBilalShafi
Copy link
Member Author

How I understand this PR

Could be a nice compromise though if buying a new one is not worth it 😃

@romgrk
Copy link
Contributor

romgrk commented Apr 3, 2024

Lol yeah. To make it clear I'm also perfectly ok with the PR. I think we could really use more hires, don't have enough time to deal with everything.

@MBilalShafi MBilalShafi merged commit 65b9549 into mui:master Apr 4, 2024
12 of 15 checks passed
@MBilalShafi MBilalShafi deleted the coldef-changes-grid-fix branch April 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Demo ColDefChangesGridNoSnap crashes
3 participants