[core] Use describeTreeView for icons tests
#12672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
flaviendelangle
commented
Apr 4, 2024
| @@ -35,7 +35,11 @@ export interface RichTreeViewSlots extends DefaultTreeViewPluginSlots { | |||
| export interface RichTreeViewSlotProps<R extends {}, Multiple extends boolean | undefined> | |||
| extends DefaultTreeViewPluginSlotProps { | |||
| root?: SlotComponentProps<'ul', {}, RichTreeViewProps<R, Multiple>>; | |||
| item?: SlotComponentProps<typeof TreeItem, {}, RichTreeViewItemSlotOwnerState>; | |||
| item?: SlotComponentPropsFromProps< | |||
There was a problem hiding this comment.
I had some typing issues while writing those tests so I improved the typing of this slot.
SlotComponentPropsFromProps allows us to skip the typeof TreeItem which can be expensive.
I also added TreeItem2Props which was completely missing
| @@ -157,6 +157,10 @@ const useUtilityClasses = (ownerState: TreeItem2OwnerState) => { | |||
| return composeClasses(slots, getTreeItemUtilityClass, classes); | |||
| }; | |||
|
|
|||
| type TreeItem2Component = (( | |||
There was a problem hiding this comment.
Forgot to have this one for consistency
| @@ -14,15 +14,15 @@ import { | |||
| DescribeTreeViewItem, | |||
| } from './describeTreeView.types'; | |||
|
|
|||
| const innerDescribeTreeView = <TPlugin extends TreeViewAnyPluginSignature>( | |||
| const innerDescribeTreeView = <TPlugins extends TreeViewAnyPluginSignature[]>( | |||
There was a problem hiding this comment.
I now pass an array of plugins. I needed it to access defaultExpandedItems in useTreeIcons.test.tsx
flaviendelangle
changed the title
describeTreeView for icons tests
11 tasks
|
Deploy preview: https://deploy-preview-12672--material-ui-x.netlify.app/ |
1 task
noraleonte
approved these changes
Apr 8, 2024
packages/x-tree-view/src/internals/plugins/useTreeViewIcons/useTreeViewIcons.test.tsx
Outdated
Show resolved
Hide resolved
…eTreeViewIcons.test.tsx Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12433
Part of #12434
The new tests are a lot more detailed but the idea remains the same