[TreeView] Improve performance by removing getNavigableChildrenIds method
#12713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
performance
component: tree view
flaviendelangle
commented
Apr 9, 2024
| : [itemBId, itemAId]; | ||
| }; | ||
|
|
||
| export const getNavigableItemsInRange = ( |
There was a problem hiding this comment.
I added an index lookup in #12213, I will extract it into a standalone PR
| * Another way to put it is which item is shallower in a trémaux tree | ||
| * https://en.wikipedia.org/wiki/Tr%C3%A9maux_tree | ||
| */ | ||
| const findOrderInTremauxTree = ( |
There was a problem hiding this comment.
Pure copy / paste
flaviendelangle
force-pushed
the
remove-getNavigableChildrenIds
branch
from
ab612ae
to
aeaaf3d
Compare
|
Deploy preview: https://deploy-preview-12713--material-ui-x.netlify.app/ |
flaviendelangle
commented
Apr 10, 2024
| : [itemBId, itemAId]; | ||
| }; | ||
|
|
||
| export const getNavigableItemsInRange = ( |
There was a problem hiding this comment.
I added an index lookup in #12213, I will extract it into a standalone PR
LukasTy
changed the title
getNavigableChildrenIds methodgetNavigableChildrenIds method
LukasTy
approved these changes
Apr 10, 2024
|
This part of the Tree View is probably the most tested, which makes me quite confident, but yeah it's a non trivial changer 😬 |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires to review #12729 before because it is merged inside this one.
Extracted from #12703
Part of #10300
The
instance.getNavigableChildrenIdswas looping on all the items to check if they were navigable or not and it was used a lot.For exemple, sometime several times per item when generating a range of items.