Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use describeTreeView in existing tests for useTreeViewItems #12732

Merged
merged 6 commits into from Apr 11, 2024
Merged

[core] Use describeTreeView in existing tests for useTreeViewItems #12732

merged 6 commits into from Apr 11, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 10, 2024 •
edited

Part of #12433

This is required before I start migrating the tests of useTreeViewItems

  • Add support for error boundary in describeTreeView
  • Refacto test renderer in describeTreeView to avoid code duplication
  • Add the item and tree component names are params of the test runner (I kept the "setup" param even if it's redundant because it makes it super easy to only execute the test in one setup, which I do super often for debugging)

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 10, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 10, 2024
@flaviendelangle flaviendelangle changed the title [core] Use describeTreeView in existing tests for useTreeViewItems [core] Use describeTreeView in existing tests for useTreeViewItems Apr 10, 2024
@flaviendelangle flaviendelangle mentioned this pull request Apr 10, 2024
Open
11 tasks
@mui-bot
Copy link

mui-bot commented Apr 10, 2024 •
edited

Deploy preview: https://deploy-preview-12732--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e3cdc3c

michelengelen
michelengelen approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! :shipit:

@flaviendelangle flaviendelangle merged commit cca7bd4 into mui:master Apr 11, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the describeTreeView-duplicate-id branch April 11, 2024 07:06
@mnathsnyk mnathsnyk mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flaviendelangle @mui-bot @michelengelen