[charts] Add z-axis to colorize scatter charts #12738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-12738--material-ui-x.netlify.app/ Updated pages: |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
force-pushed
the
add-z-axis
branch
from
833b304
to
63763b5
Compare
JCQuintas
reviewed
Apr 16, 2024
docs/translations/api-docs/charts/scatter-chart/scatter-chart.json
Outdated
Show resolved
Hide resolved
packages/x-charts/src/ChartsTooltip/ChartsAxisTooltipContent.tsx
Outdated
Show resolved
Hide resolved
packages/x-charts/src/ChartsTooltip/ChartsItemTooltipContent.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for your careful look. I added one commit per suggestion |
JCQuintas
approved these changes
Apr 17, 2024
| 4. The series color | ||
|
|
||
| :::info | ||
| The z-axis is a third axis that allows to customize scatter points independently from their position. |
There was a problem hiding this comment.
Is this an API you saw on another library?
It's clearly a valid use-case, but I'm curious to know if this is the classic way of solving it
There was a problem hiding this comment.
The naming is used in Rechart
https://recharts.org/en-US/examples/BubbleChart
<ZAxis type="number" dataKey="value" domain={domain} range={range} />For Echart, they have a similar idea called visualMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup of #12490
TODO:
zvalue the same wayxandyare currently handled by the scatter series. And azAxis.datathat will simplify the work with other charts such as the bar chartI'm not a big fan of exporting the
ZAxisProviderbut it's the only way I see to le it available for compositionChangelog