[pickers] Fix desktop date time Pickers grid layout #12748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
regression
|
Deploy preview: https://deploy-preview-12748--material-ui-x.netlify.app/ |
| @@ -91,8 +91,9 @@ const rendererInterceptor = function rendererInterceptor< | |||
| availableRangePositions: [rangePosition], | |||
| view: !isTimeViewActive ? popperView : 'day', | |||
| views: rendererProps.views.filter(isDatePickerView), | |||
| sx: [{ gridColumn: 1 }, ...finalProps.sx], | |||
There was a problem hiding this comment.
We often do the following:
sx={[...(Array.isArray(formControlSx) ? formControlSx : [formControlSx])]}
Are we sure finalProps.sx is an array here?
There was a problem hiding this comment.
In this case we are sure:
If my memory serves well, I've tested and identified that there is no way for otherProps.sx to be present here. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12726
This was a problem for both
DesktopDateTimePicker(a regression as compared to v6) and theDesktopDateTimeRangePicker.The
Layout.contentWrapperelement has adisplay: gridstyle in case of Desktop Date Time (Range) Pickers.It causes the layout to behave differently, on what kind of children are added.
With this change, all the grid children have explicitly specified
gridColumnproperty to be aware of the position they should be placed in.