Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use describeTreeView for type-ahead tests #12811

Merged
merged 17 commits into from Apr 25, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 17, 2024

Part of #12433
Blocked by #12698

I'm splitting the migration of this plugin's tests because it's basically half of the tests of the tree view 馃槅
I am splitting the test file into 1 describe per entry of the big switch in useTreeViewKeyboardNavigation, that way it's easy to know where a test should live. I'll see how many tests don't fit well in one of these blocks.

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 17, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 17, 2024
@flaviendelangle flaviendelangle changed the title Type ahead test [core] Use describeTreeView for type-ahead tests Apr 17, 2024
@flaviendelangle flaviendelangle force-pushed the type-ahead-test branch 2 times, most recently from 952b8da to 6e72b9a Compare April 17, 2024 12:03
@mui-bot
Copy link

mui-bot commented Apr 17, 2024

Deploy preview: https://deploy-preview-12811--material-ui-x.netlify.app/

Generated by 馃毇 dangerJS against 5669017

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 19, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review April 22, 2024 06:42
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. 馃憦

@flaviendelangle flaviendelangle merged commit 20af68d into mui:master Apr 25, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the type-ahead-test branch April 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants