Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Use the @mui/docs/HighlightedCode #12848

Merged
merged 11 commits into from
Apr 26, 2024
Merged

[docs-infra] Use the @mui/docs/HighlightedCode #12848

merged 11 commits into from
Apr 26, 2024

Conversation

alexfauquette
Copy link
Member

No description provided.

@alexfauquette alexfauquette added the core Infrastructure work going on behind the scenes label Apr 19, 2024
@mui-bot
Copy link

mui-bot commented Apr 19, 2024 •
edited

Deploy preview: https://deploy-preview-12848--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against e9ecb01

@alexfauquette alexfauquette changed the title Bump monorepo [docs-infra] Use the @mui/docs/HighlightedCode Apr 19, 2024
LukasTy
LukasTy reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems off with these icons sizing. 🙈 🤷
Screenshot 2024-04-19 at 16 43 17

tsconfig.json Show resolved Hide resolved
@alexfauquette
Copy link
Member Author

Something seems off with these icons sizing. 🙈 🤷

Should it be bigger? 👼

I thaught this PR was released, but not yet. Will need to wait for core release mui/material-ui#39603

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@alexfauquette alexfauquette mentioned this pull request Apr 24, 2024
Merged
1 task
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2024
LukasTy
LukasTy approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏 👍
Great to see that the monorepo patch can be dropped. 💯 🎉

.circleci/config.yml Outdated Show resolved Hide resolved
@alexfauquette
Update .circleci/config.yml
e9ecb01 
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@LukasTy LukasTy added the scope: docs-infra Specific to the docs-infra product label Apr 26, 2024
@alexfauquette alexfauquette merged commit 2b4a75d into mui:master Apr 26, 2024
18 checks passed
@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
@alexfauquette @LukasTy @joakimtveter
[docs-infra] Use the @mui/docs/HighlightedCode (mui#12848)
f983706 
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexfauquette @mui-bot @LukasTy