Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Closer sync with eslint config of codebase #12864

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 21, 2024

A step to simplify the eslint config in the codebase.

@mui-bot
Copy link

mui-bot commented Apr 21, 2024

Deploy preview: https://deploy-preview-12864--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ebf4157

@oliviertassinari oliviertassinari added the scope: code-infra Specific to the core-infra product label Apr 21, 2024
@oliviertassinari oliviertassinari changed the title [code-infra] Rule already in code-infra [code-infra] Remove rule already in code-infra Apr 21, 2024
@oliviertassinari oliviertassinari changed the title [code-infra] Remove rule already in code-infra [code-infra] Remove eslint rule already in code-infra Apr 21, 2024
@oliviertassinari oliviertassinari force-pushed the code-infra-remove-dead-config branch 4 times, most recently from 13c9315 to 94a2fe8 Compare April 21, 2024 16:18
Comment on lines -124 to -129
{
files: ['docs/data/**/*.js', 'docs/data/**/*.tsx'],
rules: {
'filenames/match-exported': ['error'],
},
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already moved to code-infra

@oliviertassinari oliviertassinari changed the title [code-infra] Remove eslint rule already in code-infra [code-infra] Closer sync with eslint config of codebase Apr 21, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Apr 22, 2024
@oliviertassinari oliviertassinari merged commit 4b07dfd into mui:master Apr 22, 2024
18 checks passed
@oliviertassinari oliviertassinari deleted the code-infra-remove-dead-config branch April 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants