Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields] Allow empty textField slot placeholder value #13148

Merged
merged 8 commits into from
May 16, 2024
Merged

[fields] Allow empty textField slot placeholder value #13148

merged 8 commits into from
May 16, 2024

Commits on May 16, 2024

  1. fix: improves placeholder prop verification to allow empty placeholde… 

    …r in textField
    Arthur Balduini authored and Arthur Balduini committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a2bc2be View commit details
    Browse the repository at this point in the history

  2. test: adds more tests on empty placeholder scenario

    Arthur Balduini authored and Arthur Balduini committed May 16, 2024
    Configuration menu
    Copy the full SHA
    442c3ec View commit details
    Browse the repository at this point in the history

  3. fix lint and prettier issues

    Arthur Balduini authored and Arthur Balduini committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0543df6 View commit details
    Browse the repository at this point in the history

  4. simplifies placeholder prop verification

    Arthur Balduini authored and Arthur Balduini committed May 16, 2024
    Configuration menu
    Copy the full SHA
    658c29c View commit details
    Browse the repository at this point in the history

  5. removes unnecessary parameter from dependecies array

    Arthur Balduini authored and Arthur Balduini committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d9d4964 View commit details
    Browse the repository at this point in the history

  6. removes unnecessary placaholder fallback

    Arthur Balduini authored and Arthur Balduini committed May 16, 2024
    Configuration menu
    Copy the full SHA
    78007e0 View commit details
    Browse the repository at this point in the history

  7. Removes unnecessary test 

    Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Arthur Suh Balduini <34691066+arthurbalduini@users.noreply.github.com>
    @arthurbalduini @LukasTy
    arthurbalduini and LukasTy committed May 16, 2024
    Configuration menu
    Copy the full SHA
    622ee27 View commit details
    Browse the repository at this point in the history

  8. uses lowercase in test description 

    Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Signed-off-by: Arthur Suh Balduini <34691066+arthurbalduini@users.noreply.github.com>
    @arthurbalduini @flaviendelangle
    arthurbalduini and flaviendelangle committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fd2ea8c View commit details
    Browse the repository at this point in the history